Skip to content

paul(ci): single step#1756

Open
paul-nechifor wants to merge 1 commit intodevfrom
paul/feat/single-ci
Open

paul(ci): single step#1756
paul-nechifor wants to merge 1 commit intodevfrom
paul/feat/single-ci

Conversation

@paul-nechifor
Copy link
Copy Markdown
Contributor

Problem

Closes DIM-XXX

Solution

Breaking Changes

How to Test

Contributor License Agreement

  • I have read and approved the CLA.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 7, 2026

Greptile Summary

This PR consolidates the previously separate tests.yml workflow into ci.yml as a single checks job, and updates docs/development/docker.md to reference ci.yml. The job runs pytest (without coverage on PRs, with coverage on pushes to main/dev) followed by mypy type-checking.

Confidence Score: 5/5

Safe to merge — the consolidation is clean and the new ci.yml correctly handles both PR and push event types.

No P0 or P1 issues found. The single remaining observation (no workflow_dispatch trigger) is a minor P2 convenience concern that doesn't affect correctness.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Consolidated tests + mypy into a single 'checks' job; tests run without coverage on PRs, with coverage on push; no workflow_dispatch trigger
.github/workflows/docker-build.yml Docker build workflow — appears unchanged or minimally changed; multi-stage image build with correct change detection
docs/development/docker.md Updated CI reference from tests.yml to ci.yml; documentation is accurate

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Push to main/dev\nor Pull Request] --> B{paths-ignore\n**.md?}
    B -- Only .md files --> Z[Skip CI]
    B -- Other files --> C{Draft PR?}
    C -- Yes --> Z
    C -- No --> D[checks job]
    D --> E[actions/checkout]
    E --> F[Fix permissions]
    F --> G[uv sync --all-extras --no-extra dds --frozen]
    G --> H[Remove pydrake stubs]
    H --> I{Event type?}
    I -- pull_request --> J[pytest\nnot tool or mujoco]
    I -- push --> K[coverage run\npytest\nnot tool or mujoco]
    K --> L[coverage combine\n& report]
    J --> M[mypy dimos\nif not cancelled]
    L --> M
    M --> N{push event?}
    N -- Yes --> O[Upload coverage\nartifact]
    N -- No --> P[Done]
    O --> P
    M --> Q{Failure?}
    Q -- Yes --> R[df -h disk check]
Loading

Reviews (1): Last reviewed commit: "paul(ci): single step" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant